Fix handling of SSH network errors#179
Merged
apocas merged 1 commit intoapocas:masterfrom Jan 3, 2025
Merged
Conversation
… throwing an exception when appropriate
This was referenced Sep 29, 2024
Closed
Contributor
|
@apocas just wanted to ping you on this if you haven't seen it yet. Would definitely be nice to have. |
Contributor
Author
|
@apocas could we get this merged if there are no issues with it? |
Owner
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes handling ssh connection errors by using error callback instead of throwing an exception when appropriate.
This resolves issue apocas/dockerode#764 and replaced pull request #163